SQA shortened code review, example
Author:Miro Kresonja, SQA manager
Date:12/10/98
Version:1.0
Code Deficiencies/Defects:
- Class/Method: DemonGUI/SetupLayout
- Not enough comments
- Any/All/Sum init should be moved where the buttons are defined
- Consts in Add() should be documented
- Setmode() should be used
- Class/Method: DrawableMap/All
- Not enough comments
- More parentheses should be added (ex. any || ...)
- Class/Method: ServerThread/Run
- SetFinal() call extraneous
- while (true) construct should be replaced (loop restructured)
- Class/Method: ClientEngine/Constructor
- Fix spelling (nulll)
- Symbolic mod_id = -1 - add symbolic value
- ReceiveMap (..., -1) - add symbolic value
- Class/Method: ServerRMI/RegisterDemon
Revision history:
Version 1.0 (created) - 12/10/98